Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: which-key not showing #22

Closed
bmag opened this issue Jul 9, 2015 · 2 comments
Closed

BUG: which-key not showing #22

bmag opened this issue Jul 9, 2015 · 2 comments

Comments

@bmag
Copy link
Contributor

bmag commented Jul 9, 2015

With vanilla emacs, which-key does not show at all. Works fine with spacemacs, though.

Steps to reproduce:

  1. emacs -Q -l path/to/s.el -l path/to/which-key.el
  2. M-x which-key-mode
  3. C-x
    Expected result: which-key shown in the minibuffer
    Actual result: which-key isn't shown at all

Probably introduced by some recent change.
Tried emacs 24.3, 24.5 and 25, same behavior. On spacemacs I don't experience this bug - which-key works as expected.

@justbur justbur closed this as completed in 7f96e4d Jul 9, 2015
@justbur
Copy link
Owner

justbur commented Jul 9, 2015

Can you try it now?

I check directly for the key-binding pointing to a keymap now. In vanilla emacs, this-single-command-keys returns a symbol so the bug was in the logic for the update function

@bmag
Copy link
Contributor Author

bmag commented Jul 9, 2015

Works!

bmag pushed a commit to bmag/emacs-which-key that referenced this issue Jul 9, 2015
@bmag bmag mentioned this issue Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants