Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which-key vs. guide-key screen shots #29

Closed
bmag opened this issue Jul 11, 2015 · 3 comments
Closed

which-key vs. guide-key screen shots #29

bmag opened this issue Jul 11, 2015 · 3 comments

Comments

@bmag
Copy link
Contributor

bmag commented Jul 11, 2015

I've done some screen shots to show the difference between which-key and guide-key, so you can use them if you want.

3 horizontally-split windows, which-key, (which-key/setup-side-window-right):
which-key-right
Compare with guide-key, (setq guide-key/popup-window-position 'right):
guide-key-right
guide-key shows less shortcuts, and the windows are not split evenly.

2 vertically-split windows, which-key, (which-key/setup-side-window-bottom):
which-key-bottom
Compare with guide-key, (setq guide-key/popup-window-position 'bottom):
guide-key-bottom
guide-key shows less shortcuts, and the windows are not split evenly. You can see that which-key doesn't fully show "x" and "z" on the far right, but it's still much better than guide-key.

@justbur
Copy link
Owner

justbur commented Jul 11, 2015

Looks good thanks. Want to add them to the readme? Could also just link to
this issue
On Sat, Jul 11, 2015 at 4:17 AM Bar notifications@github.com wrote:

I've done some screen shots to show the difference between which-key and
guide-key, so you can use them if you want.

3 horizontally-split windows, which-key,
(which-key/setup-side-window-right):
[image: which-key-right]
https://cloud.githubusercontent.com/assets/4334375/8633002/954c14f2-27bd-11e5-8e75-a04ca1f23987.png
Compare with guide-key, (setq guide-key/popup-window-position 'right):
[image: guide-key-right]
https://cloud.githubusercontent.com/assets/4334375/8633004/b6da22da-27bd-11e5-8ebf-609e3e80542a.png
guide-key shows less shortcuts, and the windows are not split evenly.

2 vertically-split windows, which-key,
(which-key/setup-side-window-bottom):
[image: which-key-bottom]
https://cloud.githubusercontent.com/assets/4334375/8633010/f8617406-27bd-11e5-998c-101bb9b137eb.png
Compare with guide-key, (setq guide-key/popup-window-position 'bottom):
[image: guide-key-bottom]
https://cloud.githubusercontent.com/assets/4334375/8633014/0909b156-27be-11e5-8f41-6c064cc71697.png
guide-key shows less shortcuts, and the windows are not split evenly. You
can see that which-key doesn't fully show "x" and "z" on the far right, but
it's still much better than guide-key.


Reply to this email directly or view it on GitHub
#29.

@bmag
Copy link
Contributor Author

bmag commented Jul 11, 2015

I think it would be nice to add them to the readme. Should I do it or you?

@justbur
Copy link
Owner

justbur commented Jul 11, 2015

Sure if you don't mind.

There's still some bugs with the layout functions that I need to fix. I
think that's why the text might be getting cut off.
On Sat, Jul 11, 2015 at 11:12 AM Bar notifications@github.com wrote:

I think it would be nice to add them to the readme. Should I do it or you?


Reply to this email directly or view it on GitHub
#29 (comment)
.

bmag pushed a commit to bmag/emacs-which-key that referenced this issue Jul 11, 2015
justbur added a commit that referenced this issue Jul 11, 2015
Start special-features section in readme #29
@bmag bmag closed this as completed Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants