Skip to content
This repository has been archived by the owner on Jul 9, 2023. It is now read-only.

excluded host are not allowed #32

Closed
mergoktas opened this issue Jan 13, 2016 · 2 comments
Closed

excluded host are not allowed #32

mergoktas opened this issue Jan 13, 2016 · 2 comments
Labels
Milestone

Comments

@mergoktas
Copy link

if an host name is in the excluded list like
ProxyServer.ExcludedHttpsHostNameRegex.Add(".youtube.com");
then proxy closing down the connection. Then it is not possible to access the website.
In our case youtube. Please test the proxy with above line.

I think, it should just by pass the request directly to server if it is in the excluded list.
Like a by pass proxy. If it is not in the excluded list then we should be able to modify the request and response, Am I right or mistaken?

@justcoding121 justcoding121 added this to the up-for-grab milestone Jan 20, 2016
@justcoding121
Copy link
Owner

As the name indicates the exclusion is only valid for https requests. Browser know that its talking to a proxy not to the server. So each time it initiates a secure connection, it expects the proxy to tunnel Https requests by sending something like CONNECT youtube.com. However we trick the browser by lying to it that we are tunneling the request, but in reality we fake it with self-signed server certificate so that we can decrypt the traffic.

So in short if you are accessing youtube.com on http://youtube.com, proxy won't exclude the request. (Notice that request body is always relayed unless you decide to read it). However if youtube.com is in the ExcludedHttpsHostNameRegex list then all Https connections to youtube will be tunneled. You won't see that in request/response event handlers.

That is the expectation, but as you reported its not working properly as we expect.

justcoding121 added a commit that referenced this issue Feb 6, 2016
fix multiple issues reported
@justcoding121
Copy link
Owner

This has been addressed in release branch

justcoding121 added a commit that referenced this issue Oct 18, 2017
fix multiple issues reported
justcoding121 added a commit that referenced this issue Oct 19, 2017
fix multiple issues reported
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants