[bug] Integration of old Dolby Vision profiles 2, 3 and 6 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per T-REC-H.265 Annex E.3 VUI Semantics, Colour Primaries, Transfer Characteristics and Matris Coeffs, when not present in the VUI, should be = 2 (unspecified) by default. Plus code simplification: DVCompatibility is not compulsory in the DoVi descriptor.
See table from https://forum.blu-ray.com/showpost.php?p=12875562&postcount=645 Profiles 2,3 and 6 to be included -despite these profiles being obsolote on new equipment.
jcdr428
changed the title
|
@justdan96 this commit is now complete and ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
So it started with a small correction, but the more I search on DV profiles, the more I find...
From https://forum.blu-ray.com/showpost.php?p=12875562&postcount=645 I have now included DV profiles 2, 3 and 6 (deprecated on new equipment).
Plus As per T-REC-H.265 Annex E.3 VUI Semantics, Colour Primaries, Transfer Characteristics and Matrix Coefficients, when not present in the VUI, should be = 2 (Unspecified) by default. Value 0 is reserved for future use.
Plus code simplification: DVCompatibility is not compulsory in the DoVi descriptor.
Plus change HDMV descriptor to non-HDMV 'HEVC' registration descriptor for HEVC DV tracks.