Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] User Select HDMV descriptors #282

Merged
merged 7 commits into from
Apr 25, 2020

Conversation

jcdr428
Copy link
Collaborator

@jcdr428 jcdr428 commented Apr 18, 2020

Changes the behavior of the "Generate HDMV compatible TS" checkbox in the "General" tab:

For "TS muxing" mode, the box is unchecked by default and can be checked;
For "M2TS muxing" mode, the box is checked by default and can be unchecked;
For all other modes (i.e. Blu-ray and demux), the box is checked by default and greyed out.

Closes issue/request #273 and #208 (comment)

@jcdr428
Copy link
Collaborator Author

jcdr428 commented Apr 19, 2020

@abakum yes you have to build from the commit, or take the build on my fork.

@abakum
Copy link
Contributor

abakum commented Apr 19, 2020

I did it via fork. GUI ok, PGS as conceived, but no warning:

MUXOPT --no-pcr-on-video-pid --vbr  --vbv-len=500
V_MPEG4/ISO/MVC, "C:\msys64\home\Konstantin.Abakumov\mvc.mkv", insertSEI, contSPS, track=1, lang=eng, subTrack=1
V_MPEG4/ISO/AVC, "C:\msys64\home\Konstantin.Abakumov\mvc.mkv", insertSEI, contSPS, track=1, lang=eng, subTrack=2
A_AC3, "C:\msys64\home\Konstantin.Abakumov\mvc.mkv", track=2, lang=rus
#S_HDMV/PGS, "C:\msys64\home\Konstantin.Abakumov\mvc.mkv", fps=25, track=3, lang=rus
S_TEXT/UTF8, "C:\msys64\home\Konstantin.Abakumov\mvc.mkv",font-name="Impact",font-size=65,font-color=0xffffffff,bottom-offset=24,font-border=5,text-align=center,fadein-time=0.1,fadeout-time=0.1,video-width=1920,video-height=1080,fps=25, track=4, lang=rus

tsMuxeR version git-0ece8e8. github.com/justdan96/tsMuxer
Decoding H264 stream (track 1): H.264/MVC Views: 2 Profile: High@4.2  Resolution: 1920:1080p  Frame rate: 25
MVC muxing fps is not set. Get fps from stream. Value: 25
Decoding H264 stream (track 2): Profile: High@4.2  Resolution: 1920:1080p  Frame rate: 25
H.264 muxing fps is not set. Get fps from stream. Value: 25
H264 bitstream changed: insert nal unit delimiters
H264 bitstream changed: insert nal unit delimiters
Decoding AC3 stream (track 3): Bitrate: 256Kbps Sample Rate: 48KHz Channels: 2
Decoding PGS stream (track 4):  Resolution: 1920:1080  Frame rate: 25
Processed 100 video frames
Processed 100 video frames
Flushing write buffer
Mux successful complete
Muxing time: 0 sec

@abakum
Copy link
Contributor

abakum commented Apr 19, 2020

Warning: PGS might not work without HDMV descriptors.

@abakum
Copy link
Contributor

abakum commented Apr 19, 2020

It is a pity that instead of --new-audio-pes now --hdmv-descriptors. This means that the new tsMuxer will not be compatible with the old one.
Anyone who used --new-audio-pes in meta files will be surprised why there are no hdmv-descriptors in ts or m2ts

@jcdr428
Copy link
Collaborator Author

jcdr428 commented Apr 19, 2020

@abakum yes indeed. But does it make sense to keep calling the hdmv descriptor option "new-audio-pes", when this new PES stream_id is only a small part of what the option is doing ? Is there any sense still using the old GUI when xavery has incuded a build for XP ? Note that there will still be HDMV descriptors, only the AC3 stream_id changes.

Edit: for the warning, I will change LTRACE(LT_WARN, 0, to LTRACE(LT_WARN, 2,

@abakum
Copy link
Contributor

abakum commented Apr 19, 2020

It would be great for those who are used to the old tsMuxer to leave the action of the old --new-audio-pes similar to the new --hdmv-descriptors

@jcdr428
Copy link
Collaborator Author

jcdr428 commented Apr 19, 2020

Ok, I'll include both --new-audio-pes --hdmv-descriptors for the option...

@lighterowl lighterowl merged commit 330bb47 into justdan96:master Apr 25, 2020
@justdan96 justdan96 added the enhancement New feature or request label Apr 27, 2020
@jcdr428 jcdr428 deleted the Optional_hdmv_descriptors branch May 3, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants