Automatic V3 for HEVC #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows tsMuxer to automatically switch to Blu-ray V3 when HEVC is detected.
|
Great! I can take a quick look at the GUI code in the next few days - or is that in the pipeline? |
lighterowl
reviewed
Dec 27, 2019
As noted by @xavery, m_HevcFound is already a bool. The cast is redundant.
|
Keep HevcFound value to true.
|
@xavery the patch is complete. The modification to the GUI is a "nice to have" item which can be done separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows tsMuxer to automatically switch to Blu-ray V3 when HEVC is detected.
The -v3 option is still needed to manually select blu-ray V3 version for AVC. However IMO it would be better to select the GUI V3 option in the tab "Blu-ray", rather than the two added UHD radio buttons on the main tab.