WIP: Split sites.json into separate files #186
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet, just opening this to show the progress.
sites.json
is clearly becoming unmaintainable and a pain with constant merge conflicts. Splitting them out seems to be the best bet.Right now there's a temporary
parse.json
file which will create a new JSON file for each site listed undersites.json
. This would only be used once for the transition.In
read.php
is an example for pulling each separate JSON file. This'd become part of the build process.I've also changed
notes
,notes_it
,notes_de
to be:which I think is a better way to present the data. Will have to work with Mike to update the Chrome plugin, or use a workaround.
Also, it may be a good idea to allow giving each site multiple names. For example in the case of the StackExchange network, Gawker etc. But some thought will need to go into how that's presented in the UI.