Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Split sites.json into separate files #186

Closed
wants to merge 1 commit into from

Conversation

danharper
Copy link
Contributor

Do not merge yet, just opening this to show the progress.


sites.json is clearly becoming unmaintainable and a pain with constant merge conflicts. Splitting them out seems to be the best bet.


Right now there's a temporary parse.json file which will create a new JSON file for each site listed under sites.json. This would only be used once for the transition.

In read.php is an example for pulling each separate JSON file. This'd become part of the build process.

I've also changed notes, notes_it, notes_de to be:

"notes": {
    "en": "...",
    "de": "...",
    "it": "..."
}

which I think is a better way to present the data. Will have to work with Mike to update the Chrome plugin, or use a workaround.

Also, it may be a good idea to allow giving each site multiple names. For example in the case of the StackExchange network, Gawker etc. But some thought will need to go into how that's presented in the UI.

@buzzb0x
Copy link
Contributor

buzzb0x commented Sep 1, 2013

I was just requesting pull for a french translation so you'd have to take that into account.

@rknightuk
Copy link
Collaborator

Won't be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants