Fix bug identified in diagnosis of production incident #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaynevanasperen
commented
Jul 2, 2020
shaynevanasperen
commented
- Log when we don't have a matching handler for the given message type.
- If two consumers are subscribed to a queue that has multiple message types in it, one of them may not be able to handle all the messages (each handled a subset). So we need to return the message to the queue for the other subscriber to try handling it.
* Log when we don't have a matching handler for the given message type. * If two consumers are subscribed to a queue that has multiple message types in it, one of them may not be able to handle all the messages (each handled a subset). So we need to return the message to the queue for the other subscriber to try handling it.
ghost
removed their request for review
There was a problem hiding this comment.
Needs a version bump for the v6 branch:
https://github.com/justeat/JustSaying/blob/162bdab29b0a44698457cae8f0eeb349ec89a742/version.props#L3
Co-authored-by: Martin Costello <martin@martincostello.com>
Thanks. Done 👍 |
martincostello
approved these changes
Jul 2, 2020
|
Also need to make sure we don't forget to put this fix into the default branch as well. |
gkinsman
reviewed
Jul 2, 2020
JustSaying.UnitTests/AwsTools/MessageHandling/MessageDispatcherTests/WhenDispatchingMessage.cs
Outdated
Show resolved
Hide resolved
gkinsman
reviewed
Jul 2, 2020
|
Apparently I closed this! That's news to me |
…ed handler, and make log assertion in unit tests less strict
slang25
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.