This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Intermittent failures in Shock v6 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
June 9, 2021 15:30
…lates. Added tests.
danlages
approved these changes
Jun 25, 2021
| @@ -26,12 +26,57 @@ class RouteTests: ShockTestCase { | |||
| } | |||
|
|
|||
| func testSimpleRouteWithVariables() { | |||
| let route: MockHTTPRoute = .simple(method: .get, urlPath: "/simple/:foo", code: 200, filename: "testSimpleRoute.txt") | |||
| let route: MockHTTPRoute = .simple(method: .get, urlPath: "/simple/:foo", code: 200, filename: "testSimpleRouteWithVariables.txt") | |||
| private func handleResponse(forResponseContext middlewareContext: MiddlewareContext, in channelHandlerContext: ChannelHandlerContext) { | ||
| private func handleResponse(forResponseContext middlewareContext: MiddlewareContext, | ||
| in channelHandlerContext: ChannelHandlerContext, | ||
| version: HTTPVersion) { | ||
|
|
||
| // TODO |
There was a problem hiding this comment.
It's not super clear what is To be done here? Should this comment be updated or even removed?
There was a problem hiding this comment.
Just formatting.
| responseFactory: self.responseFactory) | ||
| finalMiddleware.insert(routeMiddleware, at: 0) | ||
| } | ||
| let responder = MiddlwareResponder(middleware: finalMiddleware, |
There was a problem hiding this comment.
Just a suggestion
Suggested change
| let responder = MiddlwareResponder(middleware: finalMiddleware, | |
| let responder = MiddlwareResponder(middleware: finalMiddleware, |
|
Really nice PR @antoniostrijdom - Super clean. |
gigisommo
approved these changes
Jun 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing intermittent failures on our CI system for Shock v6.
This PR:
EventLoop.urlPath.Hashableroutes in favour of an array of structs mapping routes to hander closures.Equatableimplementation (wasn't dealing with paths with wildcards correctly).