This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
V9-0.0 beta.5 - fix circular reference #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieomaguire
commented
Jun 21, 2022
FayeCarter
approved these changes
Jun 21, 2022
kevinrodrigues
approved these changes
Jun 22, 2022
ashleynolan
reviewed
Jun 22, 2022
| @@ -53,7 +54,7 @@ | |||
| th, | |||
| td { | |||
| padding: $table-cell-padding; | |||
| line-height: v.$line-height-base; | |||
| line-height: units.$line-height-base; | |||
There was a problem hiding this comment.
I'd be tempted if this is the only reference to $line-height-base, just to replace the reference with the function call instead -> line-height()
ashleynolan
added a commit
that referenced
this pull request
Aug 9, 2022
* v9.0.0-beta.0 (#369) * Commenting out dependencies (migration) * v9.0.0 - Migrate to use & forward initial work. * v9.0.0 - Migrate to use & forward initial work. * v9.0.0-beta.0 - Move to use & forward syntax. * v9.0.0-beta.0 - add templates back in. * v9.0.0-beta.0 - resolve paths. * v9.0.0-beta.0 - fix paths. * Updating README and CHANGELOG * v9.0.0-beta.0 - Move trumps back. * v9.0.0-beta.0 - Move trumps to correct position * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. * v9.0.0-beta.0 - PR comments. Co-authored-by: ashleynolan <nolly00@gmail.com> * v9.0.0-beta.1 - Fixed mixin reference. (#370) * v9.0.0-beta.1 - Fixed mixin reference. * v9.0.0-beta.1 - update changelog. * v9.0.0-beta.2 - update @use rules in _type.scss (#371) * fix line-height function call * bump beta version * import as wildcard * remove wildcard from use statements * update changelog * fix zindex * V9.0.0 beta.4 - fix some missing modules (#373) * update functions * update mixin * update changelog and bump package version * V9-0.0 beta.5 - fix circular reference (#375) * update functions * update mixin * update changelog and bump package version * remove circular references from variables, funcs and mixins * update version and changelog * remove debug code * tidy code * fozzie@v9.0.0-beta.6 - Scss unit testing (#376) * install sass-true * install glob * add working function unit tests * test a mixin * bump package and changelog * rename some tests * Update CHANGELOG.md Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@justeattakeaway.com> * Update src/test/scss/scss.spec.js Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@justeattakeaway.com> * Update src/test/scss/scss.spec.js Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@justeattakeaway.com> * update test paths * remove eslint override * update test names * rename setup file * Update src/test/scss/tools/mixins/type.spec.scss Co-authored-by: Xander Marjoram <xander.marjoram@just-eat.com> Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@justeattakeaway.com> Co-authored-by: Xander Marjoram <xander.marjoram@just-eat.com> * v9.0.0-beta.7 - scss unit tests on publish (#377) * v8.3.0 - Add sass:map. (#372) * v8.3.0 - Add sass:map. * v8.3.0 - PR comment. * test scss before publishing * update test script to run concurrently * add circleci config * v8.4.0 - Circleci setup (#378) * Add .circleci/config.yml * Add .circleci/config.yml * setup circle * remove travis config Co-authored-by: Kevin Rodrigues <kevin.rodrigues@just-eat.com> * v9.0.0-beta.8 - Remove tilde import. (#382) * v9.0.0-beta.8 - Remove tilde import. * v9.0.0-beta.8 - Remove tilde import. * v9.0.0-beta.9 - Remove listingSkeleton mixin (#383) * Remove listingSkeleton mixin and bump version * Update readme Co-authored-by: Kathy Lee <wing.lee@takeaway.com> * v9.0.0-beta.10 – $font-size-base fix and minor design token update (#384) Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@cd2qgxd4hp.lan> * v9.0.0-beta.11 – font-size mixin updated to new default and package updates (#385) Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@cd2qgxd4hp.lan> * v9.0.0-beta.12 - Add back listing skeleton. (#386) * v9.0.0-beta.12 - Add back listing skeleton. * v9.0.0-beta.12 - Fix spelling. * v9.0.0 - PR comment. * v9.0.0 - version release v9 * v9.0.0 - remove changelog entry. * v9.0.0 - Add back previous beta log. Co-authored-by: ashleynolan <nolly00@gmail.com> Co-authored-by: Jamie Maguire <jamieolivermaguire@googlemail.com> Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@justeattakeaway.com> Co-authored-by: Xander Marjoram <xander.marjoram@just-eat.com> Co-authored-by: Kathy Lee <kathy.wingkilee@gmail.com> Co-authored-by: Kathy Lee <wing.lee@takeaway.com> Co-authored-by: Ashley Watson-Nolan <ashley.watson-nolan@cd2qgxd4hp.lan>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v9.0.0-beta.5
June 21, 2022
Changed
$fozzie-breakpointsout of variables file and into the breakpoints helper file to remove circular reference$line-height-baseto be the default output of theline-heightfunction it was previously calling (also to remove a circular reference)