Merge pull request #172 from yousifh/skip-metrics

Allow IEndpointSource to return null Endpoint
justeattakeaway · Apr 8, 2019 · d72b96c · d72b96c
2 parents 6112cc2 + b114ee3
commit d72b96c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/JustEat.StatsD/SocketTransport.cs b/src/JustEat.StatsD/SocketTransport.cs
@@ -44,7 +44,13 @@ public void Send(in ArraySegment<byte> metric)
                 return;
             }
 
-            var pool = GetPool(_endpointSource.GetEndpoint());
+            var endpoint = _endpointSource.GetEndpoint();
+            if (endpoint == null)
+            {
+                return;
+            }
+
+            var pool = GetPool(endpoint);
             var socket = pool.PopOrCreate();
 
             try

diff --git a/tests/JustEat.StatsD.Tests/SocketTransportTests.cs b/tests/JustEat.StatsD.Tests/SocketTransportTests.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Net;
 using JustEat.StatsD.EndpointLookups;
+using Moq;
 using Shouldly;
 using Xunit;
 
@@ -72,6 +73,17 @@ public static void SocketTransportIsNoopForEmptyArray()
             }
         }
 
+        [Fact]
+        public static void SocketTransportIsNoopForNullEndpoint()
+        {
+            var endpointSource = Mock.Of<IEndPointSource>();
+
+            using (var transport = new SocketTransport(endpointSource, SocketProtocol.IP))
+            {
+                transport.Send("teststat:1|c");
+            }
+        }
+
         private static IEndPointSource LocalStatsEndpoint()
         {
             return new SimpleEndpointSource(new IPEndPoint(IPAddress.Loopback, StatsDConfiguration.DefaultPort));