f-footer@v4.26.0 - Add Percy Visual Regression Tests #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaNg2332
previously approved these changes
Jun 10, 2021
DamianMullins
previously approved these changes
Jun 10, 2021
siggerzz
dismissed stale reviews from DamianMullins and JoshuaNg2332
via
252ebf1
…into footer-visual-reg
…into footer-visual-reg resolve merge conflict.
…-components into footer-visual-reg
…into footer-visual-reg
|
@siggerzz Looks like you need to add a version bump and changelog entry for the root, f-button, f-checkout, f-cookie-banner components? |
…into footer-visual-reg
JoshuaNg2332
previously approved these changes
Jun 17, 2021
…into footer-visual-reg
| @@ -36,7 +36,7 @@ | |||
| "@justeat/eslint-config-fozzie": "3.4.1", | |||
| "@justeat/fozzie": "5.0.0-beta.8", | |||
| "@justeat/stylelint-config-fozzie": "2.2.0", | |||
| "@percy/cli": "1.0.0-beta.48", | |||
| "@percy/cli": "1.0.0-beta.52", | |||
There was a problem hiding this comment.
Looks like the danger checks require a version bump on here as well.
DamianMullins
previously approved these changes
Jun 17, 2021
JoshuaNg2332
previously approved these changes
Jun 17, 2021
siggerzz
dismissed stale reviews from JoshuaNg2332 and DamianMullins
via
cfa0796
DamianMullins
approved these changes
Jun 17, 2021
JoshuaNg2332
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.26.0
June 15, 2021
Added