Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make phantomjs a production dependency #9

Closed
wants to merge 1 commit into from
Closed

Make phantomjs a production dependency #9

wants to merge 1 commit into from

Conversation

apeckham
Copy link

I moved phantomjs to dependencies (not devDependencies), because node-lambda skips devDependencies with "npm install --production", so phantomjs was missing from node_modules in the zip file.

Without this change I couldn't get "Hello from phantom" to work in the Lambda console.

Thanks!

I moved phantomjs to dependencies (not devDependencies), because node-lambda skips devDependencies with "npm install --production", so phantomjs was missing from node_modules in the zip file.
@justengland
Copy link
Owner

The reason it is a dev dependency was that allows me to use npm install locally and run the project on my make. It is supposed to pull in the amazon linux dependency in manually so it can run both on my local machine and also work remotely as well.

I have never really been a fan of the developing using the Lambda console, it is not as nice as my local machine for development.

I have been working on revamping how that stuff is pulled in so it will be a little more seamless, until that is finished feel free to fork the repo and make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants