Skip to content

Commit

Permalink
Renames expressions to expressionPool
Browse files Browse the repository at this point in the history
  • Loading branch information
justin-schroeder committed Apr 15, 2023
1 parent a940bfc commit 17d9237
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
12 changes: 6 additions & 6 deletions src/expressions.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ArrowExpression } from './html'

export const expressions: Array<number | ArrowExpression> = []
export const expressionPool: Array<number | ArrowExpression> = []
const expressionObservers: CallableFunction[] = []
let cursor = 0

Expand All @@ -12,9 +12,9 @@ let cursor = 0
export function storeExpressions(expSlots: ArrowExpression[]): number {
const len = expSlots.length
const pointer = cursor
expressions[cursor++] = len
expressionPool[cursor++] = len
for (let i = 0; i < len; i++) {
expressions[cursor++] = expSlots[i]
expressionPool[cursor++] = expSlots[i]
}
return pointer
}
Expand All @@ -28,13 +28,13 @@ export function updateExpressions(
sourcePointer: number,
toPointer: number
): void {
const len = expressions[sourcePointer] as number
const len = expressionPool[sourcePointer] as number
for (let i = 1; i <= len; i++) {
expressions[toPointer + i] = expressions[sourcePointer + i]
expressionPool[toPointer + i] = expressionPool[sourcePointer + i]
delete expressionObservers[sourcePointer + i]
}
for (let i = 1; i <= len; i++) {
expressionObservers[toPointer + i]?.(expressions[toPointer + i])
expressionObservers[toPointer + i]?.(expressionPool[toPointer + i])
}
}

Expand Down
10 changes: 5 additions & 5 deletions src/html.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { watch } from './reactive'
import { isChunk, isTpl, isType, queue } from './common'
import {
expressions,
expressionPool,
onExpressionUpdate,
storeExpressions,
updateExpressions,
Expand Down Expand Up @@ -358,7 +358,7 @@ function createBindings(
chunk: Chunk,
expressionPointer: number
): ArrowFragment {
const totalPaths = expressions[expressionPointer] as number
const totalPaths = expressionPool[expressionPointer] as number
const stackStart = bindingStackPos + 1
for (let i = 0; i < totalPaths; i++) {
const path = chunk.paths[i]
Expand Down Expand Up @@ -400,7 +400,7 @@ function createNodeBinding(
parentChunk: Chunk
) {
let fragment: DocumentFragment | Text | Comment
const expression = expressions[expressionPointer]
const expression = expressionPool[expressionPointer]
if (isTpl(expression) || Array.isArray(expression)) {
// We are dealing with a template that is not reactive. Render it.
fragment = createRenderFn()(expression)!
Expand Down Expand Up @@ -436,14 +436,14 @@ function createAttrBinding(
parentChunk: Chunk
) {
if (!isType(node, 1)) return
const expression = expressions[expressionPointer]
const expression = expressionPool[expressionPointer]
if (attrName[0] === '@') {
const event = attrName.substring(1)
if (!parentChunk.a) parentChunk.a = new AbortController()
node.addEventListener(
event,
(...args) =>
(expressions[expressionPointer] as CallableFunction)?.(
(expressionPool[expressionPointer] as CallableFunction)?.(
...args
) as unknown as EventListener,
{
Expand Down
4 changes: 2 additions & 2 deletions src/reactive.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { isR, isO, queue } from './common'
import { expressions, onExpressionUpdate } from './expressions'
import { expressionPool, onExpressionUpdate } from './expressions'
import { ArrowFunction, ArrowRenderable } from './html'

/**
Expand Down Expand Up @@ -470,7 +470,7 @@ export function watch<
startTracking()

const effectValue = isPointer
? (expressions[effect as number] as ArrowFunction)()
? (expressionPool[effect as number] as ArrowFunction)()
: (effect as CallableFunction)()

stopTracking(watchKey, rerun!)
Expand Down

0 comments on commit 17d9237

Please sign in to comment.