Use http.Error to also set text/plain content type #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ func correctReason(t *testing.T, reason error) http.Handler { | |||
| " but it failed with the reason %#v", reason, got) | |||
| } | |||
| // Writes the default failure code | |||
| w.WriteHeader(FailureCode) | |||
| http.Error(w, "", FailureCode) | |||
There was a problem hiding this comment.
This is a bit weird. Test is not really using the default error handler
There was a problem hiding this comment.
This one is only used to check for the correct reason of failure in tests. I guess it could fall back on defaultFailureHandler.
justinas
added a commit
that referenced
this pull request
Dec 8, 2015
Use http.Error to also set text/plain content type. Fixes #31
|
Thanks! |
|
Nice, thanks for nosurf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31