This repository has been archived by the owner on Feb 2, 2019. It is now read-only.
Feature/Angular 2 #309
Merged
Feature/Angular 2 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed some config changes for my developer setup on windows.
Update dependencies to @angular rc.5 and @angular2-material to alpha.7-4
Remove tests from build to simplify upgrade. Testing using our own example app.
Removing modules that were recommended to be superceeded by their @angular2-material counterparts in [this gist] (https://gist.github.com/ollwenjones/d33b181773d8c8d7f4293cf6e6c4005b) by @ollwenjones Leaving scss for our example app.
Created Pagination NgModule class and corrected TS compiler and Angular errors.
Created NgModule for MdContent directive
Created NgModule class for MdDataTable
Created NgModule class for MdDivider
Created NgModule class for MdPeekaboo
Created NgModule class for Md* validator directives
Created NgModule class for MdSubheader
Created NgModule class for MdBackdrop
Create NgModule classes for ng2-material in Node.js and browser. Removed exports from deprecated/removed modules.
Will need to be provided on the component level.
This doesn't make tests run yet, but needs to be done
* Remove unused styles We are using the angular2-material equivalents of these styles * Fix shadowed input The `range-format` input of md-pagination-range was getting overriden by the null value of the parent pagination directive. * Update to Angular rc.6 and Typescript 2.0 - Updated all package deps to their latest versions. - Updated just enough code to make the typescript compiler happy with new packages. Have not tested components other than the ones in our demo app. - Fixed pagination require from unstable source. Only imports from the root of @angular modules are to be trusted - Removed MdCard styles from components barell. - Added forRoot static method to both Ng2MaterialModule versions. * Update to rc.7 Update dependencies to rc7, not observing any necessary code changes. * Use local installation of typescript to build * bump pre version
Alpha 8-2 has updated dependencies to angular 2.0.0
The angular material 2 project has changed their packaging. They now distribute everything under the single package `@angular/material`. Updated package files and removed references to any `@angular2-material/*` packages
Setting default theme variables to default so that they can be overidden in app.
Feature/angular material - update to a PR that will likely stay open a while.
- we don't add any testing to the example site, so they're just noise.
- remove grunt-exec and specify a custom typescript compiler location in the grunt-ts configuration
- as pointed out by @ollwenjones the styles are different than the official material2 implementation. let's avoid confusion. todo: look at updating the card examples (or remove them if it's too much work)
…ngular apis - use TestBed for specs - update componentSanityCheck to use TestBed - update karma and systemjs configs to look like angular2 quickstart (https://github.com/angular/quickstart) - remove `main` function wrapper in test files and call describe when the module is imported (again to match angular/quickstart) - add dialog module - break pagination tests into individual files - add MdServicesModule for importing services BREAKING CHANGE: remove md-card component The card component conflicts with the official @angular/material/card implementation. Please use the official component. For more information see: https://github.com/angular/material2/tree/master/src/lib/card
- the forms module has changed quite a bit and look competent enough to exist without these components. BREAKING CHANGE: removed md-messages components and prefer to use standard FormsModule
- use async() to wrap any it() or beforeEach() calls that do promise based async stuff. - use `TestBed.get(ServiceTypeName)` instead of `inject()` when a service instance is needed in a test.
BREAKING CHANGE: Remove support for automated testing of IE and unreliable builds of Chrome beta.
BREAKING CHANGE: Remove support for automated testing of Chrome 39 and Android 4.4
|
@ollwenjones @ashleahhill thanks for starting this. I have some time that I can contribute this week to help out. I decided to drop a few extra components:
I updated a few other things and made the PR build go green:
I haven't looked at the actual site itself. |
- move some testing stuff out of the first line - update language to downplay any suggestion that users should create issues. Instead suggest they provide a fix for the community. - remove gitter link (I never monitor it despite good intentions.)
- Android is failing to start sometimes. I have no patience for sauce flakiness. - Make all browsers run on Windows 10 in an attempt to reduce test start times
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of progress, yet lots to do.
Made the decision to push progress with dev commits, so anyone who wants to contribute can see what has been done so far.
Upgrade Components Themselves:
Ng2MaterialModuleNgModuleclassNgModuleclassesNgModuleclassRemove in favor of angular2/material implementations (8 components):
.md-elevationclassesplatform/testing/boostrapplatform/testing/utilcomponentSanityCheck