check arity of validator conditionals before calling it with arguments #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes paperclip upload work fixes formtastic#999
|
Woo! Thanks! Could there be a simple test added to file_input_spec.rb to ensure that we don't introduce a regression in the future? Have you confirmed that this is working for you in your app? If we can get a teeny bit of coverage in there I'll get it merged and push out a RC for testing Any concerns that it could introduce a bug elsewhere @sobrinho? |
|
Yes, the fix has solved the issue in our app :) I'll see if I get to writing some specs. Not really sure where to start here. Were you referring to testing the logic in validations.rb in general or rather the bit I touched in validator_relevant? |
|
Merging as-is, I can't find a simple way to test this. |
justinfrench
added a commit
that referenced
this pull request
Mar 31, 2014
Fix issues with Paperclip by checking arity of validator conditionals before calling it with arguments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes paperclip upload work
fixes #999 as suggested there by @derekprior