Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize our CI stack a bit #1011

Merged
merged 5 commits into from
Mar 31, 2014
Merged

Modernize our CI stack a bit #1011

merged 5 commits into from
Mar 31, 2014

Conversation

justinfrench
Copy link
Member

No changes to production code or the API. Here's a summary of what was done and why:

  • Added a new gemfile for Rails 4.0.4 explicitly rather than just Rails ~> 4.0.0 (I'm wondering if we should upgrade all of the gemfiles to actively target latest releases, or keep it vague like they already are)
  • Specifically testing against Rails 4.0.4 exposed a compatibility issue with I18n where we needed to set I18n.enforce_available_locales in the test suite (it was deprecated in previous versions, none of us were watching)
  • Added Rails 4.0.4 to the build matrix as well, since there's an possibility of regression there.
  • Discovered that REE and Ruby 1.8.7 were failing on Travis because newer versions of rake require Ruby 1.9, so I fixed the dependency on rake to a lesser version for now (there's a separate issue for dropping old rubies).
  • Testing all of this stuff with the older version of Appraisal was a pain in the ass, so I upgrade to a new beta version, which I think is fine for a development-only dependency.

As there's no change to production code or the API (only our build and test suite), I'm just merging this straight in on green build.

justinfrench added a commit that referenced this pull request Mar 31, 2014
@justinfrench justinfrench merged commit e385841 into master Mar 31, 2014
@justinfrench justinfrench deleted the modernize-ci branch March 31, 2014 06:42
@oliverklee
Copy link
Contributor

👍 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants