Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid reference to LabelHelper #1153

Merged
merged 1 commit into from
Jun 19, 2015

Conversation

markedmondson
Copy link
Contributor

There is no such label_helper

There is no such labels_helper
@markedmondson
Copy link
Contributor Author

Actually, it'd be awesome to have a LabelHelper that doesn't just pass to the default FormBuilder to be able to do something like:

f.label :datetime
f.input :datetime_date, label: false
f.input :datetime_time, label: false

In the case where there's wrapping around the input, then the output can be customized to wrap two inputs with one label. E.g

<div id="datetime">
    <label for="datetime">Datetime</label>
    <div class="field"><input name="datetime_date" /></div>
    <div class="field"><input name="datetime_time" /></div>
</div>

justinfrench added a commit that referenced this pull request Jun 19, 2015
Remove autoload of LabelHelper which doesn't exist
@justinfrench justinfrench merged commit 681fcfd into formtastic:master Jun 19, 2015
@justinfrench
Copy link
Member

@markedmondson I'd need to see some code, so feel free to create an issue or rough-out the beginnings of a PR. Have merged this one, thanks.

@markedmondson
Copy link
Contributor Author

I have working code: https://github.com/justinfrench/formtastic/compare/master...Guestfolio:label-helper?expand=1

However I can't get the tests to run, making it tough to add my own.. any ideas? Segmentation fault right after:

>> BUNDLE_GEMFILE=/Users/markedmondson/Sites/formtastic/gemfiles/rails_3.2.gemfile bundle exec rake

/Library/Ruby/Gems/2.0.0/gems/json-1.8.3/lib/json/ext/parser.bundle: [BUG] Segmentation fault at 0x00000000000418
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]

@justinfrench
Copy link
Member

@markedmondson no ideas on the segfault, but if you pseudo-code a test scenario and start a PR, I'd be happy to help polish it off — I'm just not comfortable starting or defining the goals the tests for code I didn't write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants