Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AR validations should be checked better for figuring out required fields #610

Merged
merged 4 commits into from
Jul 4, 2011
Merged

AR validations should be checked better for figuring out required fields #610

merged 4 commits into from
Jul 4, 2011

Commits on Jun 27, 2011

  1. Added failing test for validates_length_of :maximum-only setting 

    Signed-off-by: Balazs Nagy <julsevern@gmail.com>
    @julian7
    julian7 committed Jun 27, 2011
    Configuration menu
    Copy the full SHA
    d1c3365 View commit details
    Browse the repository at this point in the history

  2. html5 validators should reflect AR validations more strictly 

    * validates_presence_of has no options
* validates_inclusion_of can be optional only if :allow_blank => true
* validates_length_of can be optional if either :allow_blank => true,
  :minimum is > 0, or :within's least value is > 0

Signed-off-by: Balazs Nagy <julsevern@gmail.com>
    @julian7
    julian7 committed Jun 27, 2011
    Configuration menu
    Copy the full SHA
    be7285f View commit details
    Browse the repository at this point in the history

  3. Better specs for converting AR validators to required parameters 

    Signed-off-by: Balazs Nagy <julsevern@gmail.com>
    @julian7
    julian7 committed Jun 27, 2011
    Configuration menu
    Copy the full SHA
    7b22ff0 View commit details
    Browse the repository at this point in the history

  4. input_helper_spec refactor, typo fix 

    Signed-off-by: Balazs Nagy <julsevern@gmail.com>
    @julian7
    julian7 committed Jun 27, 2011
    Configuration menu
    Copy the full SHA
    bbc4052 View commit details
    Browse the repository at this point in the history