Don't use ActionView::Helpers::InstanceTag.check_box_checked? anymore #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though ActionView::Helpers::InstanceTag exists in Rails 4, the check_box_checked? method is gone, so the defined? check that was put in earlier did not have the desired effect.
I propose to always use our own boolean_checked? method since that works across all Rails versions.
This fixes the rendering of check boxes in Rails 4 (edge Rails).