Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide ca.crt for androids (in docker container) #108

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

l3iggs
Copy link
Contributor

@l3iggs l3iggs commented Jul 25, 2016

This generates ca.crt (required for some/all? android phones) into the container 10 seconds after the container is started so that it can be downloaded just like ca.pem is.
See https://github.com/justinleewells/pogo-optimizer/issues/104 (and several other issues apparently)

@l3iggs l3iggs changed the title provide ca.crt for androids provide ca.crt for androids (in docker container) Jul 25, 2016
@justinleewells
Copy link
Owner

justinleewells commented Jul 25, 2016

The only problem is that this will introduce another dependency for Windows.

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

Huh? No it doesn't.
The openssl command comes in the container.
By the way, your README.md says you don't support windows.

@justinleewells
Copy link
Owner

I want to switch to an Electron app instead of Docker in the very near future.

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

Oh, well I have no idea what Electron is. This fix is for docker.
Are you planning on dropping the Dockerfile from your repo?

@justinleewells
Copy link
Owner

In the future, that is the intent. For now I guess we can merge this PR.

Side note: Electron is a bundled app that doesn't require any of this stuff. I'm just waiting on a library to be finished before I pull the trigger.

@justinleewells justinleewells merged commit 9c98dbb into justinleewells:master Jul 25, 2016
@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

Cool.
Btw, is there some way to just tell the MITM proxy to generate the right certificate? That's how this should actually be solved instead of doing this conversion.

@justinleewells
Copy link
Owner

I've been looking into it, but I can't really find anything node-wise. If you find anything, make a PR because that would be ideal.

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

I've raised an issue upstream: https://github.com/rastapasta/pokemon-go-mitm-node/issues/47
Let's see what comes of that.

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

And another one even further upstream: joeferner/node-http-mitm-proxy#96

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 25, 2016

node-forge is what's used by the double upstream parent project to generate the cert in the first place. Maybe it could also convert...

@l3iggs
Copy link
Contributor Author

l3iggs commented Jul 26, 2016

This is the ticket:
joeferner/node-http-mitm-proxy#96 (comment)

@justinleewells
Copy link
Owner

Looks good. I'll work on adding it to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants