Unskip tests that needed flutter#44152

justinmc · Mar 11, 2021 · 526b219 · 526b219
1 parent b7785aa
commit 526b219
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/flutter/test/cupertino/context_menu_test.dart b/packages/flutter/test/cupertino/context_menu_test.dart
@@ -121,7 +121,7 @@ void main() {
       await gesture.up();
       await tester.pumpAndSettle();
       expect(_findStatic(), findsOneWidget);
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
   });
 
   group('CupertinoContextMenu when open', () {
@@ -141,7 +141,7 @@ void main() {
       await tester.tapAt(const Offset(1.0, 1.0));
       await tester.pumpAndSettle();
       expect(_findStatic(), findsNothing);
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
 
     testWidgets('Can close CupertinoContextMenu by dragging down', (WidgetTester tester) async {
       final Widget child = _getChild();
@@ -183,7 +183,7 @@ void main() {
       await swipeGesture.up();
       await tester.pumpAndSettle();
       expect(_findStatic(), findsNothing);
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
 
     testWidgets('Can close CupertinoContextMenu by flinging down', (WidgetTester tester) async {
       final Widget child = _getChild();
@@ -208,7 +208,7 @@ void main() {
       await tester.fling(_findStaticChild(child), const Offset(0.0, 100.0), 1000.0);
       await tester.pumpAndSettle();
       expect(_findStatic(), findsNothing);
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
 
     testWidgets("Backdrop is added using ModalRoute's filter parameter", (WidgetTester tester) async {
       final Widget child = _getChild();
@@ -223,7 +223,7 @@ void main() {
       await tester.pumpAndSettle();
       expect(_findStatic(), findsOneWidget);
       expect(find.byType(BackdropFilter), findsOneWidget);
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
   });
 
   group("Open layout differs depending on child's position on screen", () {
@@ -298,7 +298,7 @@ void main() {
 
       // Set the screen back to its normal size.
       await binding.setSurfaceSize(const Size(800.0, 600.0));
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
 
     testWidgets('Landscape', (WidgetTester tester) async {
       // Pump a CupertinoContextMenu in the center of the screen and open it.
@@ -363,6 +363,6 @@ void main() {
       expect(find.byType(CupertinoContextMenuAction), findsOneWidget);
       final Offset right = tester.getTopLeft(find.byType(CupertinoContextMenuAction));
       expect(right.dx, lessThan(left.dx));
-    }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+    });
   });
 }
diff --git a/packages/flutter/test/widgets/shader_mask_test.dart b/packages/flutter/test/widgets/shader_mask_test.dart
@@ -19,7 +19,7 @@ void main() {
   testWidgets('Can be constructed', (WidgetTester tester) async {
     const Widget child = SizedBox(width: 100.0, height: 100.0);
     await tester.pumpWidget(const ShaderMask(child: child, shaderCallback: createShader));
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+  });
 
   testWidgets('Bounds rect includes offset', (WidgetTester tester) async {
     late Rect shaderBounds;
@@ -43,7 +43,7 @@ void main() {
 
     // The shader bounds rectangle should reflect the position of the centered SizedBox.
     expect(shaderBounds, equals(const Rect.fromLTWH(0.0, 0.0, 400.0, 400.0)));
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+  });
 
 
   testWidgets('Bounds rect includes offset visual inspection', (WidgetTester tester) async {
@@ -106,5 +106,5 @@ void main() {
       find.byType(RepaintBoundary),
       matchesGoldenFile('shader_mask.bounds.matches_top_left.png'),
     );
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44152
+  });
 }