You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
According to a pending pull request, compiled binaries should exist as part of repo. Potentially including a script to generate the compiled binary for Windows or other platform would be useful instead.
The reason will be displayed to describe this comment to others. Learn more.
I dont really care. He asked for a binary, and i provided. I dont see why people have such a hissy fit over such a small binary in the repo. It looks like justinmeister feels the same as he has not touched that pull request.
The reason will be displayed to describe this comment to others. Learn more.
He also hasn't touched this project in a while too. Regardless, I agree... even though it's bad practice, I've done it before too. In my case were solution binaries I didn't want my students to see the code for, but wanted to provide in the repo.
88f836f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to a pending pull request, compiled binaries should exist as part of repo. Potentially including a script to generate the compiled binary for Windows or other platform would be useful instead.
88f836f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont really care. He asked for a binary, and i provided. I dont see why people have such a hissy fit over such a small binary in the repo. It looks like justinmeister feels the same as he has not touched that pull request.
88f836f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He also hasn't touched this project in a while too. Regardless, I agree... even though it's bad practice, I've done it before too. In my case were solution binaries I didn't want my students to see the code for, but wanted to provide in the repo.