Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NumberConstraint): force positive value on first arg #316

Merged
merged 1 commit into from Oct 10, 2016

Conversation

bighappyface
Copy link
Collaborator

Resolves #315 - multipleOf is inconsistent, fails for negative numbers

@bighappyface
Copy link
Collaborator Author

@leongersen please review

@bighappyface bighappyface force-pushed the fmod-fix branch 2 times, most recently from 9994241 to c669b57 Compare October 10, 2016 00:47
Resolves jsonrainbow#315 - `multipleOf` is inconsistent, fails for negative numbers
@leongersen
Copy link

abs has no side effects and doesn't negatively affect multipleOf behaviour, test shows a previously failing case. Looks good to me.

@bighappyface bighappyface merged commit c3e11be into jsonrainbow:master Oct 10, 2016
@bighappyface bighappyface deleted the fmod-fix branch October 10, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants