Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes to .gitattributes #597

Merged
merged 1 commit into from Nov 12, 2019
Merged

Add .gitattributes to .gitattributes #597

merged 1 commit into from Nov 12, 2019

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Nov 12, 2019

No description provided.

@erayd
Copy link
Collaborator

erayd commented Nov 12, 2019

Thanks for this. Looks like there's definitely a pin failure, as per my comment on your other PR.

@reedy
Copy link
Contributor Author

reedy commented Nov 12, 2019

Thanks for this. Looks like there's definitely a pin failure, as per my comment on your other PR.

I'll have a look at it in more detail later on today (ie after I've had some sleep) and see if I can help

erayd
erayd approved these changes Nov 12, 2019
View reviewed changes
Copy link
Collaborator

@erayd erayd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed, but php-cs-fixer pin needs to be resolved before this can be merged.

Apparently I can force a merge for a failing PR if I don't do it from my phone 😁

@erayd erayd merged commit 0107607 into justinrainbow:master Nov 12, 2019
@Ayesh Ayesh mentioned this pull request May 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erayd erayd erayd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reedy @erayd