Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): placeholder position with different text-align #44

Merged
merged 1 commit into from
Nov 26, 2021
Merged

fix(css): placeholder position with different text-align #44

merged 1 commit into from
Nov 26, 2021

Conversation

anatolykopyl
Copy link
Contributor

Fixes issue where #fallbackPlaceholder becomes misaligned if parent has text-align not set to left.

This is the current demo page with

body {
    text-align: center;
}

Screen Shot 2021-11-26 at 00 36 30

@anatolykopyl anatolykopyl changed the title Fixed placeholder position with different text-align fix(css): placeholder position with different text-align Nov 25, 2021
@justinribeiro
Copy link
Owner

LGTM

@justinribeiro justinribeiro merged commit 90b64f3 into justinribeiro:main Nov 26, 2021
github-actions bot pushed a commit to cshawaus/lite-youtube that referenced this pull request Nov 19, 2023
# 1.0.0 (2023-11-19)

### Bug Fixes

* **badges:** calc min and compression sizes ([0f0bd68](0f0bd68))
* clean up dom define, do not double stamp attr ([451769c](451769c))
* **css:** change activation header precedent for hiding ([justinribeiro#9](https://github.com/cshawaus/lite-youtube/issues/9)) ([d8149fc](d8149fc))
* **height:** remove min-height, use 16:9 default to make it easier ([justinribeiro#2](https://github.com/cshawaus/lite-youtube/issues/2)) ([345976f](345976f))
* **iframe:** loader missing flag check ([justinribeiro#8](https://github.com/cshawaus/lite-youtube/issues/8)) ([ff5ae2d](ff5ae2d))
* intersection observer injection no longer autoplays ([justinribeiro#35](https://github.com/cshawaus/lite-youtube/issues/35)) ([9bec0c9](9bec0c9))
* missing attrchange for playlistid ([f8a0646](f8a0646))
* **package:** Make the package a valid ES module ([justinribeiro#76](https://github.com/cshawaus/lite-youtube/issues/76)) ([d3de76b](d3de76b)), closes [justinribeiro#75](https://github.com/cshawaus/lite-youtube/issues/75)
* **placeholder:** placeholder position with mis-aligned with text-align at parent ([justinribeiro#44](https://github.com/cshawaus/lite-youtube/issues/44)) ([90b64f3](90b64f3))
* play button cursor type ([justinribeiro#63](https://github.com/cshawaus/lite-youtube/issues/63)) ([02a0d6e](02a0d6e))
* **preload:** prevent multiple rules in multi-instance scenario ([justinribeiro#69](https://github.com/cshawaus/lite-youtube/issues/69)) ([e85e5b1](e85e5b1))
* resolve dead case path, add observe and coverage ([justinribeiro#95](https://github.com/cshawaus/lite-youtube/issues/95)) ([50c254b](50c254b))
* **safari:** fixed style within shadow fails on Safari ([justinribeiro#4](https://github.com/cshawaus/lite-youtube/issues/4)) ([81e5be9](81e5be9))
* **test:** resolve test errors with latest accessibility PR ([972a8f6](972a8f6))

### Features

* add liteYoutubeIframeLoaded event for iframe load ([justinribeiro#39](https://github.com/cshawaus/lite-youtube/issues/39)) ([a870383](a870383))
* add params option for yt query params ([c2be735](c2be735))
* add playlist loading support ([justinribeiro#40](https://github.com/cshawaus/lite-youtube/issues/40)) ([10ea534](10ea534))
* add poster quality attr ([justinribeiro#36](https://github.com/cshawaus/lite-youtube/issues/36)) ([dc569a3](dc569a3))
* add shadow dom parts support ([9d0c32a](9d0c32a))
* add youtube-nocookie bool attr ([justinribeiro#38](https://github.com/cshawaus/lite-youtube/issues/38)) ([e23de5b](e23de5b))
* **autoload:** use intersection observer to auto-load on scroll ([06f4eb3](06f4eb3))
* convert to typescript ([justinribeiro#10](https://github.com/cshawaus/lite-youtube/issues/10)) ([a2c4977](a2c4977))
* **core:** add YouTube Shorts-style mobile embed interaction ([justinribeiro#67](https://github.com/cshawaus/lite-youtube/issues/67)) ([ce2a16e](ce2a16e))
* **csp:** add support for csp nonce to inline style ([justinribeiro#68](https://github.com/cshawaus/lite-youtube/issues/68)) ([b255b5d](b255b5d))
* **img:** add webp placeholder support ([9cd57b5](9cd57b5))
* **locale:** add aria and locale title ([justinribeiro#1](https://github.com/cshawaus/lite-youtube/issues/1)) ([4b6a91b](4b6a91b))
* **logo:** switch to official youtube logo ([justinribeiro#82](https://github.com/cshawaus/lite-youtube/issues/82)) ([68acaf8](68acaf8))
* **poster:** add posterloading for img lazy load ([66e8751](66e8751))
* **shadowdom:** lets shadow dom this thing ([036a100](036a100))
* **time:** add video start time attr ([justinribeiro#6](https://github.com/cshawaus/lite-youtube/issues/6)) ([aa68aae](aa68aae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants