fixing #70

justinsalamon · Feb 24, 2020 · 20aaac4 · 20aaac4
1 parent 6222658
commit 20aaac4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -2,6 +2,11 @@
 
 Changelog
 ---------
+
+v.1.3.2
+~~~~~~~
+- Fixed a bug where short backgrounds did not concatenate to fill the entire soundscape.
+
 v.1.3.1
 ~~~~~~~
 - Fixed a bug with generating docs on ReadTheDocs.

diff --git a/scaper/core.py b/scaper/core.py
@@ -1709,10 +1709,11 @@ def _generate_audio(self, audio_path, ann, reverb=None,
                         cmb.convert(samplerate=self.sr,
                                     n_channels=self.n_channels,
                                     bitdepth=None)
-                        # Then trim
+                        # Then trim, using the duration as the lower limit to handle
+                        # backgrounds that are too short
                         cmb.trim(e.value['source_time'],
                                  e.value['source_time'] +
-                                 e.value['event_duration'])
+                                 max(e.value['event_duration'], self.duration))
 
                         # PROCESS BEFORE COMPUTING LUFS
                         tmpfiles_internal = []

diff --git a/scaper/version.py b/scaper/version.py
@@ -3,4 +3,4 @@
 """Version info"""
 
 short_version = '1.3'
-version = '1.3.1'
+version = '1.3.2'