Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #5: Memory leak in captured program #6

Closed
wants to merge 1 commit into from
Closed

Fix for Issue #5: Memory leak in captured program #6

wants to merge 1 commit into from

Conversation

bitterskittles
Copy link

Changed return value of BaseDXHooks.ReadFullStream to IEnumerable< byte[] >
Removed MarshalByRefObj base from Screenshot
Changed parameters of CaptureInterface.SendScreenshotResponse to (Guid, byte[][])

@bitterskittles
Copy link
Author

I decided to not change CaptureInterface.SendScreenshotResponse.
Screenshot gets binaryserialized when it crosses appdomains, and it doesn't have any methods so it doesn't have to be MarshalByRefObj. So I'll drop the base and add SerializableAttribute

@justinstenning
Copy link
Owner

See the fix for #7 to correctly address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants