Fix plugin compatibility with recent Intellij versions #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for creating this plugin, it's awesome!
Unfortunately, the published version of this plugin is not compatible with recent versions of the IDEs, because of the constrained maximum supported version. This PR fixes that by removing the upper version constraint.
In my opinion, the plugin does not contain anything that will likely change with one of the next Intellij versions. I think it's ok to remove the upper version constraint, so the plugin does not have to be republished for every new Intellij version. This is why I decided to remove the version constraint instead of just bumping it to the most recent version of Intellij.
Besides removing the version constraint, I also did two other changes:
IconLoader.getIcon
method was deprecated at some point and now also requires a Class to be passed in. Since the deprecated method could be removed at some point, I also fixed this issue.Let me know what you think about that.
Cheers,
Jan