Skip to content

Commit

Permalink
remove upload_dir from rllib launch script options
Browse files Browse the repository at this point in the history
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
  • Loading branch information
justinvyu committed Feb 1, 2024
1 parent adc0d7d commit eddce52
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions rllib/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def download_example_file(
"""
temp_file = None
if not os.path.exists(example_file):

example_url = base_url + example_file if base_url else example_file
print(f">>> Attempting to download example file {example_url}...")

Expand Down Expand Up @@ -143,7 +142,6 @@ def get_help(key: str) -> str:
ray_num_gpus="The '--num-gpus' argument to use if starting a new cluster.",
ray_num_nodes="Emulate multiple cluster nodes for debugging.",
ray_object_store_memory="--object-store-memory to use if starting a new cluster.",
upload_dir="Optional URI to sync training results to (e.g. s3://bucket).",
trace="Whether to attempt to enable eager-tracing for framework=tf2.",
torch="Whether to use PyTorch (instead of tf) as the DL framework. "
"This argument is deprecated, please use --framework to select 'torch'"
Expand Down Expand Up @@ -236,7 +234,6 @@ class CLIArguments:
CheckpointScoreAttr = typer.Option(
"training_iteration", help=get_help("sync_on_checkpoint")
)
UploadDir = typer.Option("", help=train_help.get("upload_dir"))
Trace = typer.Option(False, help=train_help.get("trace"))
LocalMode = typer.Option(False, help=train_help.get("local_mode"))
Scheduler = typer.Option("FIFO", help=get_help("scheduler"))
Expand Down
5 changes: 0 additions & 5 deletions rllib/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ def run(
resources_per_trial: str = cli.ResourcesPerTrial,
keep_checkpoints_num: int = cli.KeepCheckpointsNum,
checkpoint_score_attr: str = cli.CheckpointScoreAttr,
upload_dir: str = cli.UploadDir,
# Additional config arguments used for overriding.
v: bool = cli.V,
vv: bool = cli.VV,
Expand Down Expand Up @@ -287,7 +286,6 @@ def run(
# If no subcommand is specified, simply run the following lines as the
# "rllib train" main command.
if ctx.invoked_subcommand is None:

# we only check for backends when actually running the command. otherwise the
# start-up time is too slow.
import_backends()
Expand Down Expand Up @@ -315,9 +313,6 @@ def run(
"config": dict(config, env=env),
"restore": restore,
"num_samples": num_samples,
"sync_config": {
"upload_dir": upload_dir,
},
}
}

Expand Down

0 comments on commit eddce52

Please sign in to comment.