allow custom hipchat hosts #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 haha I needed just this:P |
| @@ -79,7 +79,7 @@ def initialize(_config = nil) | |||
| # enters an infinite loop. Any messages sent to the room will pass | |||
| # through all the included plugins. | |||
| def connect | |||
| client.connect | |||
| client.connect(config.host, config.port||5222) | |||
There was a problem hiding this comment.
It might be better to set the default port up in initialize, like the rest of the defaults.
There was a problem hiding this comment.
New commit should fix that
|
other than that, 👍! |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46