Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with weather test in a different timezone #56

Merged
merged 2 commits into from Sep 2, 2018
Merged

Fixed issue with weather test in a different timezone #56

merged 2 commits into from Sep 2, 2018

Conversation

jamsi
Copy link

@jamsi jamsi commented Mar 21, 2017

What does this PR do?

  • I detected an issue whereby specs would fail when run in my time zone (Sydney/Australia).
  • This was because pretend_now_is in the TimeWarp gem default to UTC, but the weather plugin uses Time.now.
  • The solution was to modify the tests to explicitly specify the zone using Time.parse
  • I also bumped the TimeWarp gem
  • I also added the TravisCI build badge to the Readme

@jamsi
Copy link
Author

jamsi commented Aug 28, 2018

Bump? Or close?

@justinweiss
Copy link
Owner

Sure :-) Is this repo still useful? It's been years since I've used HipChat, so I don't even know if they still support this API.

@justinweiss justinweiss merged commit a050b79 into justinweiss:master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants