Fixes #30 - end positions for attribute names include whitespaces

justinwilaby · Jun 20, 2020 · 7201d24 · 7201d24
1 parent 13ec382
commit 7201d24
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/lib/sax-wasm.wasm b/lib/sax-wasm.wasm
diff --git a/src/js/__test__/attribute.spec.ts b/src/js/__test__/attribute.spec.ts
@@ -28,6 +28,25 @@ describe('SaxWasm', () => {
     parser.end();
   });
 
+  it('should recognize boolean attributes', () => {
+    parser.write(Buffer.from('<button disabled class="primary-btn"></button>'));
+    deepStrictEqual(_event, SaxEventType.Attribute);
+    deepStrictEqual(_data.length, 2);
+    deepStrictEqual(_data[0].name, 'disabled');
+    deepStrictEqual(_data[0].value, '');
+  })
+
+  it('should not include whitespace in the attribute\'s nameEnd value', () => {
+    parser.write(Buffer.from(`<?xml version="1.0" encoding="UTF-8"?>
+<plugin
+    version       =   "1.0.0"   >
+</plugin>`));
+    deepStrictEqual(_event, SaxEventType.Attribute);
+    deepStrictEqual(_data.length, 1);
+    deepStrictEqual(_data[0].name, 'version');
+    deepStrictEqual(_data[0].nameEnd.character, 11);
+  })
+
   it('should recognize attribute names', () => {
     parser.write(Buffer.from('<body class="main"></body>'));
     deepStrictEqual(_event, SaxEventType.Attribute);

diff --git a/src/sax/parser.rs b/src/sax/parser.rs
@@ -489,7 +489,6 @@ impl SAXParser {
     }
     if grapheme == "=" {
       self.state = State::AttribValue;
-      self.attribute.name_end = (self.line, self.character - 1);
     } else {
       if grapheme == ">" {
         self.process_attribute();