Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added read stream support + optimizations #13

Merged
merged 7 commits into from
Feb 8, 2019
Merged

Added read stream support + optimizations #13

merged 7 commits into from
Feb 8, 2019

Conversation

justinwilaby
Copy link
Owner

This PR adds:

  • read-stream support for parsing very large files without growing memory.
  • Optimizations when certain events are not configured for the parser.

@coveralls
Copy link

coveralls commented Feb 6, 2019 •
edited

Pull Request Test Coverage Report for Build 168

  • 75 of 76 (98.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.8%) to 96.111%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/js/saxWasm.ts 75 76 98.68%
Totals Coverage Status
Change from base Build 154: 4.8%
Covered Lines: 122
Relevant Lines: 124
💛 - Coveralls

@justinwilaby justinwilaby merged commit bdf1d34 into master Feb 8, 2019
@justinwilaby justinwilaby deleted the read-stream branch February 8, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinwilaby @coveralls