Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - #21 Parser failing on some XML files #22

Merged
merged 1 commit into from
Nov 26, 2019
Merged

FIX - #21 Parser failing on some XML files #22

merged 1 commit into from
Nov 26, 2019

Conversation

justinwilaby
Copy link
Owner

@justinwilaby justinwilaby commented Nov 26, 2019 •
edited

Fixed an issue where flushing data mid-stream caused errant tag to appear.
@Christilut - Can you please confirm this fix?

@justinwilaby justinwilaby self-assigned this Nov 26, 2019
@justinwilaby justinwilaby mentioned this pull request Nov 26, 2019
Closed
@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited

Pull Request Test Coverage Report for Build 201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.764%
Totals Coverage Status
Change from base Build 199: 0.0%
Covered Lines: 128
Relevant Lines: 131
💛 - Coveralls

@Christilut
Copy link

Works great here! Thanks for the quick fix

@justinwilaby justinwilaby merged commit dc6c667 into master Nov 26, 2019
@justinwilaby justinwilaby deleted the bug/attribute-as-tag-name branch November 26, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinwilaby justinwilaby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinwilaby @coveralls @Christilut