Add support for DOCKER_CONTEXT environment variable #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update segment-docker_context.go to look for DOCKER_CONTEXT environment variable, and use that when setting the value of the segment. Signed-off-by: Scott Lowe <scott.lowe@scottlowe.org>
|
Is there a reason you removed the 🐳 emoji? |
|
@justjanne Sorry, that's an error on my part! I'll push another commit that restores the emoji. Apologies! |
justjanne
requested changes
Apr 19, 2022
Restore Docker emoji inadvertently removed in original commit Co-authored-by: Janne Mareike Koschinski <janne@kuschku.de>
|
@justjanne I've committed your suggestion. Apologies again for the error with the emoji. Thanks for creating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
DOCKER_CONTEXTenvironment variable, which will override the context specified by thedocker context usecommand when setting the Docker context. Accordingly,segment-docker_context.gois changed by this PR to useDOCKER_CONTEXTif specified, and use the context specified in the Docker configuration file if the environment variable is not set (the same order Docker itself uses to determine context).Fixes #350.