Merge pull request #49 from justjasongreen/scrape_horse

Fix Invalid Foaled Dates (fixes #48)

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## [Unreleased]
+
+### Fixed
+
+- Fix parsing of missing foaled dates when scraping horses (from @justjasongreen)
+
+
 ## [1.0.0b6] - 2016-07-25
 
 ### Fixed

punters_client/scraper.py

@@ -243,7 +243,10 @@ def parse_name(html):
                         elif label == 'foaled':
                             value = get_child_text(row, 'td')
                             if value is not None:
-                                profile['foaled'] = self.SOURCE_TIMEZONE.localize(datetime.strptime(value, '%d/%m/%Y'))
+                                try:
+                                    profile['foaled'] = self.SOURCE_TIMEZONE.localize(datetime.strptime(value, '%d/%m/%Y'))
+                                except (TypeError, ValueError):
+                                    profile['foaled'] = None
 
                 return profile
 

setup.cfg

@@ -27,6 +27,6 @@ first_value = 1
 
 [pytest]
 flake8-ignore = 
+    *.py E241
 	tests/* E501
 flake8-max-line-length = 120
-

tests/scraper/scrape_horse_test.py

@@ -30,3 +30,14 @@ def test_expected_values(expected_values, scraped_values):
     """The scrape_horse method should return a dictionary containing all expected values"""
 
     assert scraped_values == expected_values
+
+
+def test_invalid_foaled_date(scraper):
+
+    runner = {
+        'horse_url':    'https://www.punters.com.au/horses/Bonner_152493/'
+    }
+
+    horse = scraper.scrape_horse(runner)
+
+    assert horse['foaled'] is None