Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-ui-less reset.overrides? #6

Open
payneio opened this issue Dec 9, 2019 · 7 comments
Open

semantic-ui-less reset.overrides? #6

payneio opened this issue Dec 9, 2019 · 7 comments

Comments

@payneio
Copy link
Contributor

payneio commented Dec 9, 2019

semantic-ui-less has a file in /themes/default/globals/reset.overrides which this project does not have. Was that intentional?

@justkey007
Copy link
Owner

Yes it is intentional because in the code write in LESS everything has been mixed and it is not easy to be able to locate the location of a code related to a certain behavior. I have refactored so.

@payneio
Copy link
Contributor Author

payneio commented Dec 9, 2019

Refactored? Where did you end up putting the reset styes then? Or did you just remove them?

@payneio
Copy link
Contributor Author

payneio commented Dec 12, 2019

Sorry... maybe I'm slow, but I don't see the normalize.css rules anywhere? https://github.com/Semantic-Org/Semantic-UI-LESS/blob/master/themes/default/globals/reset.overrides

@payneio
Copy link
Contributor Author

payneio commented Dec 12, 2019

The inclusion of /*! normalize.css v7.0.0 | MIT License | github.com/necolas/normalize.css */ into Semantic-UI seems essential to the framework to make the theme behave consistently cross-platform.

@justkey007
Copy link
Owner

justkey007 commented Dec 13, 2019

The inclusion of /*! normalize.css v7.0.0 | MIT License | github.com/necolas/normalize.css */ into Semantic-UI seems essential to the framework to make the theme behave consistently cross-platform.

Yes you are right I omitted it without knowing it. As I told you, a lot of the work has been done by automation. All the .overrides files have been deleted and replaced by .style.scss for the components. So I did not pay attention to the globals folder files. Help me integrate it if you have time. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants