Add CORS_ORIGIN environment variable #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Previously, ssl-proxy assigned the
SERVER_NAME
value to theAccess-Control-Allow-Origin
header (which was not documented).One issue is that any CORS headers set by the proxied server are overridden here. Another issue is that there is no way to customize the CORS headers, which is important for any API.
In my case, I would have preferred
ssl-proxy
not override the server's headers, but at the very least I needed to be able to set theAccess-Control-Allow-Origin
header myself to a value other than the server name.This pull request adds an environment variable,
CORS_ORIGIN
, and documents it in the README. If unset, this value will default to that ofSERVER_NAME
to maintain backward compatibility. Otherwise, it allows overriding just the origin header.I hope this change helps other people in my situation!