Use transition event to check whether the animation has finished to fix visual problems caused by any performance problems. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2013 13:15
…ere the initial view you were moving from is removed too early. Now we wait for the animation to officially end rather than make assumptions.
…you are too quick.
…led again. This causes situations in which the underlying Backbone.History.fragment is the same as the fragment (or view name) which we want to switch to, yet the view which is being shown is the previous view. You can end up trapped on a view. Performance-related yet again...
|
I have made the change suggested before, and I have also fixed another performance issue relating to getting trapped on a view. Perhaps I have not fixed it in the most elegant way since I am testing whether the 'animate' class is there but it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed performance problems on iOS6 causing a white block to appear where the initial view you were moving from is removed too early. Now we wait for the animation to officially end rather than make assumptions.