Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rds-postgres URL with rdsutils.BuildAuthToken #119

Merged

Conversation

arthurzenika
Copy link
Contributor

Related : #114

job.go Show resolved Hide resolved
job.go Show resolved Hide resolved
Co-authored-by: Gaëtan Ars <29622411+gaetanars@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Copy link
Member

@dewey dewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds reasonable to me, but I don't have a way of testing it. If you tested it and it works for you I'm okay with merging it as it shouldn't be breaking anyone's workflow in any case if they don't use it.

README.md Outdated Show resolved Hide resolved
job.go Outdated Show resolved Hide resolved
job.go Outdated Show resolved Hide resolved
job.go Outdated Show resolved Hide resolved
@arthurzenika
Copy link
Contributor Author

Thanks for the review and the approval. We have a running version running in one environment so far.

@dewey dewey merged commit c7792a0 into justwatchcom:master Mar 21, 2024
1 check passed
@dewey
Copy link
Member

dewey commented Mar 21, 2024

Hey @arthurzenika, I just merged the changes and released a new version. The Docker image is also published on GitHub now. Thank you for tackling it and contributing to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants