Make poll_aws.juttle a shell script. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename poll_aws.juttle.skip to poll_aws.sh so it won't be exposed in the file explorer. Also, move the sleep/echo into that script.
| | AWS.aggregate_all | ||
| | write mysql -table 'aws_aggregation'; | ||
|
|
||
| " && tail -f /dev/null |
There was a problem hiding this comment.
So even if something goes wrong with the juttle program, the container will stay alive so you can exec into it to diagnose.
There was a problem hiding this comment.
And now it actually does that instead of by using &&.
added 2 commits
March 4, 2016 13:37
&& won't work if the juttle program exits non-zero, so just separate with semicolon.
If the poller juttle process does actually exit, echo a message saying so.
|
why is the explorer showing a file that doesn't end in |
|
Yes the explorer shows all files ending in .juttle. It used to end in .juttle, so I had it renamed to .juttle.skip. But now it's just a shell script so it won't show up. |
mstemm
pushed a commit
that referenced
this pull request
Mar 4, 2016
Make poll_aws.juttle a shell script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename poll_aws.juttle.skip to poll_aws.sh so it won't be exposed in
the file explorer.
Also, move the sleep/echo into that script.
@demmer this is what we discussed earlier.