read#handleRawResponse: return an array #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DDL statements like 'CREATE TABLE' are run, the first item of the response is an object instead of an array. Wrap it into an array in these situations.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DDL statements like 'CREATE TABLE' are run, the first item of the response is an object instead of an array. Wrap it into an array in these situations.
I didn't do a thorough investigation of why this used to work fine and doesn't now. Either we used to do this wrapping somewhere downstream (perhaps even in core juttle) or knex used to return an array in the first item. Either way, we should ensure that the returned value is an array.
@VladVega @demmer @rlgomes