delayed_endpoint_close: honor when websocket connects before job finishes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes that looks correct. sorry for the bug. I did have a test for this but it was only for the case where the websocket connects after the program has finished. |
|
and lgtm. |
go-oleg
added a commit
that referenced
this pull request
Feb 11, 2016
delayed_endpoint_close: honor when websocket connects before job finishes
|
Noting this is a fix for the previous fix for #9 (still uses the same temporary strategy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self._delayed_endpoint_closewas hangin out in the call toforEachinstead ofsetTimeout@mstemm