New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails for aggregator project #14
Comments
Given that line number it cannot have uploaded anything |
Tried the command on latest snapshot:
for scm url configured:
Exception as follows:
I'm feeling strange about the line 158 in code since it doesn't make any sense to me, but again release and tag were created sucessfully, and artifact was uploaded. |
Ok, I missed something in the log. Actually aggregator module is executed successfully, the build fails on the first child module. |
Is it possible that you forget to copy the scm section over to the child modules? |
Don't think it's a good idea. Why to duplicate your scm sections among all child modules?
|
Because that is how maven works. Maven does bad automagic to the SCM section of multi module builds.
I use the plugin in the child modules myself, so I don't think this is a reasonable default.
If you define the plugin in the parent and do not want it to apply to the children use inherited false in the plugin config |
inherited=false doesn't prevent a plugin from running in modules. Thus there is still no much gain from it since you need to specify the plugin in all modules. What won't work for release plugin. It still makes sense to add a skipModules (default=false) property to plugin configuration for aggregator projects and add a method like
Thanks, for pointing out to SCM Maven magic. So the only solution for my case is to put into child module
and move release plugin to distribution module. |
It prevents you from inheriting a defined execution from the parent which in turn prevents the plugin from running in child modules.
Things like submodule release do not work unless the scm section if defined in each child module. If you try to release without it tries to clone e.g.
Sorry, I don't really get why that would be helpful |
Exactly, it means you can't just run github-release:release. If you bind execution to a specific phase, this phase should be configured for all modules. The only workaround is to skip deployment plugin:
skipModules property will give more control, and we could run the plugin disregarding any phase without extra workaround configuration like above. Even with the workaround like here the entire life cycle (compilation, tests) is executed, but you need only to make a release. |
I still don't quite get what you are trying to do. Who in your reactor wants to publish assets to github?
|
Only reactor. Inherited=false in reactor and execution phase=deploy triggers first github release and then all child modules are compiled, tested and deployed what is overkill since you just want to release without extra stuff. But it's a standard behavior of Maven, so definitely your plugin is not aimed to fix it as far as you can work-around it by moving plugin to a child module. I think it's time to close the issue. Thanks for you great plugin, especially for new version 1.1.1. |
You can use the -N (non-recursive) parameter to just build the parent without the children. |
Build fails but the tag, release are actually created and artifact uploaded:
The text was updated successfully, but these errors were encountered: