Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New locales create wrong property names #4

Closed
svogt opened this issue Apr 26, 2012 · 5 comments
Closed

New locales create wrong property names #4

svogt opened this issue Apr 26, 2012 · 5 comments
Assignees
Labels
Milestone

Comments

@svogt
Copy link
Collaborator

svogt commented Apr 26, 2012

If you create a new locale and add the first translation (e.g. fr as locale) the generated .properties is called name_<masterlocale>_<newlocale>.properties...
<masterlocale> needs to be stripped from the name

@ghost ghost assigned jutzig Apr 26, 2012
@jutzig
Copy link
Owner

jutzig commented Apr 26, 2012

I'll try to write a unit test for this...

@jutzig
Copy link
Owner

jutzig commented Apr 26, 2012

Two new untit tests added. Not tested with real data, but should work as expected now

@jutzig jutzig closed this as completed Apr 26, 2012
@jutzig
Copy link
Owner

jutzig commented Apr 26, 2012

Isn't there some way to reference an issue in a commit comment, or link a commit to an issue?

@svogt
Copy link
Collaborator Author

svogt commented Apr 26, 2012

Sure there is, just use # in the commit message to get a comment added or use one of the following to close the issue automatically:

fixes #xxx
fixed #xxx
fix #xxx
closes #xxx
close #xxx
closed #xxx

I propose to use:
Close #xxx

on a seperate line

@jutzig
Copy link
Owner

jutzig commented Apr 26, 2012

thx, Close #xxx works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants