Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores posts with a permalink #27

Closed
JamieMason opened this issue Apr 6, 2017 · 3 comments
Closed

Ignores posts with a permalink #27

JamieMason opened this issue Apr 6, 2017 · 3 comments

Comments

@JamieMason
Copy link

Thanks for this great plugin.

I've noticed that if I give my post permalink: /somewhere front matter that it is no longer picked up by amp-jekyll, is there anything I can do to workaround this please?

@juusaw
Copy link
Owner

juusaw commented Jun 1, 2017

Hi,

I managed to get this sorted out. It seems that the page generation failed silently when the AMP post had the same permalink as the original post copied over to it. Deleting the attribute from the page fixed this. Commit ad341b2 does this.

I'll make a release soon with this fix included.

@juusaw
Copy link
Owner

juusaw commented Oct 21, 2017

Fixed in 1.0.2

@juusaw juusaw closed this as completed Oct 21, 2017
@aav7fl
Copy link

aav7fl commented Nov 10, 2017

@juusaw

Soo... this actually goes backwards for me. Like the opposite of what is happening in #29 , but I have narrowed it to this ticket/changes.

I was using a permalink with a different url, I was expecting my post (after update from 1.0.1->1.0.2) to be /amp/blog/2017/05/15/welcome-to-jekyll/, but now it is /amp/blog/2017/05/15/welcome-to-jekyll.html..

My website links are supposed to be like www.example.com/blog/2017/05/15/welcome-to-jekyll/ while my amp pages are supposed to be www.example.com/amp/blog/2017/05/15/welcome-to-jekyll/. Is this not the way it is supposed to work?

Repo that I'm using it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants