Allow path chunks to start with a colon #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths with chunks starting with colons — /like/::this/:one — are valid
but they were not parsed correctly by bidi. The reason was an exception
thrown by the java.net.URI constructor invoked in bidi/just-path.
java.net.URI assumed that a string like ":a" was missing a required URI
schema and threw. Similar issues occurred in the ClojureScript edition.
This patch solves the problem by prefixing the path with an explicit
schema file:/// before invoking the constructor. Afterwards it drops
the slash which got prepended.
Interestingly enough, replacing bidi/just-path with the following
implementation solves the problem too and according to the test suite
it doesn't appear to be introducing any regressions. This being said,
my gut feeling tells me it might bite us in the future.