Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove println calls #60

Closed
tangrammer opened this issue May 6, 2015 · 5 comments
Closed

Remove println calls #60

tangrammer opened this issue May 6, 2015 · 5 comments

Comments

@tangrammer
Copy link
Contributor

Hi guys
can we remove the println calls https://github.com/juxt/joplin/search?utf8=%E2%9C%93&q=println ?
and maybe use something like timbre https://github.com/ptaoussanis/timbre ?

thanks!
Juan

@martintrojer
Copy link
Contributor

that is the problem, replace them with what? (Without screwing up people dependencies, and/or locking them in).

Some wants to use log4j, some timbre some something else.

@tangrammer
Copy link
Contributor Author

Hi Martin,
then (simpler approach) I'd choose something to deactivate/activate println calls based in global flag value and having a fn to deactivate/activate this value

@martintrojer
Copy link
Contributor

Yeah, a silent switch sounds good (sorry taking so long).

Ragtime now supports overriding printlns aswell.

@martintrojer
Copy link
Contributor

The solution for this problem, with Joplin 0.3 onwards, is to wrap your calls to joplin with with-out-str.

So for instance in your alias.clj file simply do

(with-out-str
  (repl/migrate conf .. ..))

@tangrammer
Copy link
Contributor Author

Thanks!
El 19/08/2015 20:21, "Martin Trojer" notifications@github.com escribió:

The solution for this problems, with Joplin 0.3 onwards is to wrap your
calls to joplin.repl/migrate (etc) with with-out-str.

So for instance in your aliases file simply do

(with-out-str
(rep/migrate conf .. ..))


Reply to this email directly or view it on GitHub
#60 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants